Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting to satisfy latest checks. #106

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Conversation

jatkinson1000
Copy link
Owner

@jatkinson1000 jatkinson1000 commented Dec 9, 2024

Looks like ruff and mypy have become a little more strict in the latest versions.

This PR fixes that by updating for:

  • ruff
    • Sorting imports in __init__.py
    • Iterating over a dict using .items()
  • mypy
    • ??

@jatkinson1000 jatkinson1000 self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (99fe0a9) to head (e5ec401).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          30       30           
  Lines        1742     1742           
=======================================
  Hits         1704     1704           
  Misses         38       38           
Files with missing lines Coverage Δ
archeryutils/__init__.py 100.00% <ø> (ø)
archeryutils/classifications/__init__.py 100.00% <ø> (ø)
...s/classifications/agb_old_field_classifications.py 100.00% <100.00%> (ø)
archeryutils/handicaps/__init__.py 100.00% <ø> (ø)
archeryutils/handicaps/handicap_scheme.py 96.98% <100.00%> (ø)
archeryutils/handicaps/handicap_tables.py 90.52% <100.00%> (ø)
archeryutils/length.py 100.00% <100.00%> (ø)

@jatkinson1000
Copy link
Owner Author

@TomHall2020 This patch should fix the ruff and mypy issues you see on your branch in #103

I'm still getting to the bottom of why mypy was unhappy and ensuring that I am satisfied with the fix (I have gone off mypy a little, or perhaps I need to dial down the settings).

@TomHall2020
Copy link
Contributor

Sure thing, I guess if my stuff so far has prompted a few changes to the rest of the codebase we can merge this in and build from there.

@jatkinson1000 jatkinson1000 merged commit e0d8d00 into main Dec 15, 2024
15 checks passed
@jatkinson1000 jatkinson1000 deleted the linterfixes branch December 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants