Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some handicap_functions methods private #60

Closed
jatkinson1000 opened this issue Feb 4, 2024 · 2 comments · Fixed by #78
Closed

Make some handicap_functions methods private #60

jatkinson1000 opened this issue Feb 4, 2024 · 2 comments · Fixed by #78
Assignees
@jatkinson1000

Comments

@jatkinson1000
Copy link
Owner

All except handicap_from_score and print_handicap_table should be private.
To do this requires removing the explicit tests for any private functions and instead testing them implicitly through the above two.

This will require tests writing for print_handicap_table which should bump coverage up.
@TomHall2020
Copy link
Contributor

TomHall2020 commented Feb 6, 2024 •
edited
Loading

I wonder, does it make logical sense to remove the explicit tests? It seems unit testing is a perfectly valid reason to break the private convention and use those functions directly.

@jatkinson1000
Copy link
Owner Author

This is likely to be addressed in the upcoming PR dealing with #2
At least, it gives a significant shake up to everything and is likely to render much of this moot, I think.

@jatkinson1000 jatkinson1000 mentioned this issue Feb 23, 2024
Merged
8 tasks
@jatkinson1000 jatkinson1000 self-assigned this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jatkinson1000 jatkinson1000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handicaps refactor jatkinson1000/archeryutils
2 participants
@TomHall2020 @jatkinson1000