Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to pypi #49

Closed
TomHall2020 opened this issue Jan 8, 2024 · 8 comments · Fixed by #87
Closed

Upload to pypi #49

TomHall2020 opened this issue Jan 8, 2024 · 8 comments · Fixed by #87
Assignees

Comments

@TomHall2020
Copy link
Contributor

Is there much else that needs to be done before this can be uploaded?

Am currently working on a project using this and being able to properly install and version it rather than installing from source would be quite helpful.

Happy to try and contribute if anything needs doing to prepare for this.

@jatkinson1000
Copy link
Owner

I could probably look at doing this in its current state with a bit of tidying to be honest (done is better than perfect etc.etc.)
I was hoping to improve the field handicaps, but have been too busy to do much recently so this may become something for a later version (and it's all unofficial at the moment anyway).

Always keen to see how it's useful.
How is your project packaged at the moment, as there are ways to add git repos to dependencies and point to specific commits/hashes? This could work in the interim. See here for an example.

@jatkinson1000 jatkinson1000 self-assigned this Jan 8, 2024
@jatkinson1000
Copy link
Owner

jatkinson1000 commented Jan 9, 2024

@TomHall2020 Having refreshed my memory I think I'd like to close #2, #4, and #27 for release, as implementing these in future would likely be breaking changes, so best to set now.

#3 and #15 would be nice, but I think can be resolved in a backwards compatible way in future.

If you fancy taking a crack at #27 please do! - I have set out a rough plan for what would need doing in the issue.
Happy to help with guidance on forks/pull requests etc. if required.
I'll try and look at #4 and #2 this weekend depending on how much I freeze at a frostbite/EFAA course.

Edit: #4 has now been closed in #51
Edit: #27 has now been closed in #52 and #54
Edit: #3 has now been closed in #55
Edit: Documentation is now online following #58
Edit: #2 has now been closed by #78 (just a little bit longer than the proposed weekend...)

@TomHall2020
Copy link
Contributor Author

Yeah, #27 looks pretty straightforward I can cook something up for that.
The project isn't packaged as such, its a django web app so archeryutils is just a dependancy on the server side. At the moment the person I'm working on it with has just included this project as a submodule but the git pointer in requirements.txt would probably work better for us for now.

@TomHall2020
Copy link
Contributor Author

Hate to add to the list but theres probably one more issue to go before release, #74

@jatkinson1000
Copy link
Owner

Yeah, it's been a bugbear of mine for a while, I'll do it after #2 as it should hopefully be relatively straightforward with some default arguments.

@jatkinson1000 jatkinson1000 mentioned this issue Mar 3, 2024
8 tasks
@jatkinson1000
Copy link
Owner

Revisiting this, and once we close #57 (PR ready), #71 (PR #82 WIP), and #56 (PR #59 close) I think we are good to go.

@jatkinson1000
Copy link
Owner

#57 is now closed, #56 is now closed, #71 is only one remaining.

PR for PyPI release has been opened in #87

@jatkinson1000
Copy link
Owner

@TomHall2020 This should now be done here: https://pypi.org/project/archeryutils/

Happy pip installing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants