Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pandoc 3 #965

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Allow pandoc 3 #965

merged 5 commits into from
Jan 31, 2023

Conversation

LaurentRDC
Copy link
Collaborator

This is a simple version bump to allow pandoc-3.

I've tried my fork with my own website and everything is working as expected.

@LaurentRDC
Copy link
Collaborator Author

I had to update some of the golden tests because pandoc-3's output is different. I'm assuming that pandoc 3 is correct, but I can't really say.

Minoru
Minoru approved these changes Jan 29, 2023
View reviewed changes
Copy link
Collaborator

@Minoru Minoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good, but I'd like to know why the wai-app-static dependency was moved before I merge this.

The change in Pandoc's output is a bit unfortunate, because Hakyll's users might depend on these details in,say, their CSS. Can you please add a stub to the CHANGELOG so I don't forget to mention this when I do a release?

hakyll.cabal Outdated Show resolved Hide resolved
hakyll.cabal Show resolved Hide resolved
@Minoru
Copy link
Collaborator

Minoru commented Jan 29, 2023 •
edited
Loading

Note to self: after merging this, make a new Hackage revision and include the changes from #961 in it, because I forgot to do so last time. Also, PR mtl 2.3 support that I have on a private branch.

@Minoru Minoru merged commit 2ea5d68 into jaspervdj:master Jan 31, 2023
@Minoru
Copy link
Collaborator

Minoru commented Jan 31, 2023

Thank you!

@Minoru
Copy link
Collaborator

Minoru commented Feb 1, 2023

Note to self: after merging this, make a new Hackage revision and include the changes from #961 in it, because I forgot to do so last time. Also, PR mtl 2.3 support that I have on a private branch.

No, wait, since it needed some adjustments to tests, I'd have to make a full-fledged release for this. I hope to do it this weekend.

@ozkutuk
Copy link
Contributor

ozkutuk commented Feb 3, 2023 •
edited
Loading

Is there a particular reason why the upper constraint for Pandoc 2 has changed from < 2.20 to < 2.19.2? I depend on Nix for the CI builds of my blog and as of writing this, the Nix package repository provides pandoc == 2.19.2, so I can't build the current master of Hakyll from source with the given boundaries. Would it be a good idea to relax the upper bound on Pandoc 2 back to < 2.20?

@LaurentRDC
Copy link
Collaborator Author

Ahh this is my mistake. I wanted to write <= 2.19.2 (the last released version), but it could also be <= 2.20.

@Minoru Can you fix this on my behalf?

@Minoru
Copy link
Collaborator

Minoru commented Feb 4, 2023

Done in 909e1b3. Sorry I led you down the wrong way, it was my suggestion to use < 2.19.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minoru Minoru Minoru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaurentRDC @Minoru @ozkutuk