-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend rules docs #912
Extend rules docs #912
Conversation
7865b20
to
42098fd
Compare
Any review comments? I would like to finish this PR soon. |
Oof, sorry, I didn't realize that I've been postponing this for 4 months now! I'll make time for a review tomorrow. In the meantime, it'd be nice if you could rebase this onto the latest |
b4d0c34
to
c32d311
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience! I think this looks good. I fixed a couple typos, and in one place I'm not sure what you meant — please commit my suggestions if you agree with them, or let's discuss how to rewrite those parts better.
Co-authored-by: Alexander Batischev <eual.jp@gmail.com>
Co-authored-by: Alexander Batischev <eual.jp@gmail.com>
Co-authored-by: Alexander Batischev <eual.jp@gmail.com>
Co-authored-by: Alexander Batischev <eual.jp@gmail.com>
Cool! Thank you very much for the work and especially for the patience ^_^ Merging! |
Part of #904