Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend rules docs #912

Merged
merged 18 commits into from
Mar 12, 2022
Merged

Extend rules docs #912

merged 18 commits into from
Mar 12, 2022

Conversation

malteneuss
Copy link
Contributor

Part of #904

@malteneuss malteneuss force-pushed the extend-rules-docs branch 2 times, most recently from 7865b20 to 42098fd Compare December 8, 2021 23:53
lib/Hakyll/Core/Rules.hs Outdated Show resolved Hide resolved
lib/Hakyll/Core/Rules.hs Outdated Show resolved Hide resolved
lib/Hakyll/Core/Rules.hs Outdated Show resolved Hide resolved
@malteneuss malteneuss marked this pull request as ready for review December 8, 2021 23:54
@malteneuss malteneuss mentioned this pull request Jan 2, 2022
@malteneuss malteneuss requested a review from Minoru January 9, 2022 13:06
@malteneuss
Copy link
Contributor Author

Any review comments? I would like to finish this PR soon.

@Minoru
Copy link
Collaborator

Minoru commented Mar 8, 2022

Oof, sorry, I didn't realize that I've been postponing this for 4 months now! I'll make time for a review tomorrow.

In the meantime, it'd be nice if you could rebase this onto the latest master to fix CI here.

Copy link
Collaborator

@Minoru Minoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! I think this looks good. I fixed a couple typos, and in one place I'm not sure what you meant — please commit my suggestions if you agree with them, or let's discuss how to rewrite those parts better.

lib/Hakyll/Core/Rules.hs Outdated Show resolved Hide resolved
lib/Hakyll/Core/Rules.hs Outdated Show resolved Hide resolved
lib/Hakyll/Core/Rules.hs Outdated Show resolved Hide resolved
lib/Hakyll/Core/Rules.hs Outdated Show resolved Hide resolved
lib/Hakyll/Core/Rules.hs Outdated Show resolved Hide resolved
malteneuss and others added 5 commits March 11, 2022 23:13
Co-authored-by: Alexander Batischev <eual.jp@gmail.com>
Co-authored-by: Alexander Batischev <eual.jp@gmail.com>
Co-authored-by: Alexander Batischev <eual.jp@gmail.com>
Co-authored-by: Alexander Batischev <eual.jp@gmail.com>
@Minoru
Copy link
Collaborator

Minoru commented Mar 12, 2022

Cool! Thank you very much for the work and especially for the patience ^_^ Merging!

@Minoru Minoru merged commit 8203e8c into jaspervdj:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants