Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support processing multiple bibliography files #898

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Support processing multiple bibliography files #898

merged 2 commits into from
Oct 25, 2021

Conversation

benjamineskola
Copy link
Contributor

Pandoc Citeproc supports taking multiple bibliography files as input by passing a MetaList to the "bibliography" key instead of a single string. This keeps the original processPandocBiblio function taking a single bibliography, and adds a processPandocBiblios taking a list; the original function now just calls the new one.

It’ll take a list of bibliography items and generate filenames for them (just enumerating them) and then insert them all into the file tree, so it incidentally also replaces my previous PR too. :)

I hope this is useful to others, I thought it made sense to offer it rather than keep an entire copy of the function in my site.hs.

Still needs tests adding, which I’ll try to do shortly.

@Minoru
Copy link
Collaborator

Minoru commented Oct 24, 2021

The idea sounds good. Please ping me for a review once you got tests and they passed the CI ;)

Pandoc Citeproc supports taking multiple bibliography files as input by
passing a MetaList to the "bibliography" key instead of a single string.
This keeps the original processPandocBiblio function taking a single
bibliography, and adds a processPandocBiblios taking a list; the
original function now just calls the new one.
@Minoru Minoru mentioned this pull request Oct 24, 2021
@benjamineskola
Copy link
Contributor Author

@Minoru I believe this is now ready.

Copy link
Collaborator

@Minoru Minoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Minoru Minoru merged commit f7f2cdd into jaspervdj:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants