Better detection of dependency cycles #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks better. It cloned the code, at least. Thanks! Reviewing now; will take a while since I want to compare to the older detector, just in case. |
|
O-o-okay, I distracted myself and haven't taken a look yet. I'll try to get to it tomorrow. |
|
No rush! I just validated this fix on my personal website as well. |
Minoru
reviewed
Sep 14, 2021
Minoru
requested changes
Sep 15, 2021
Minoru
approved these changes
Sep 15, 2021
|
Okay. Thanks for your work here! 🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue fixes #878