Remove dependency on cryptonite and memory #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minoru
approved these changes
Apr 15, 2021
|
Thank you for the PR, @LaurentRDC! @jaspervdj, do you remember what the purpose of "test.hs" is? It was introduced in 030864a with no explanation, and doesn't look related to anything (no mention in the code or docs anywhere, and it mentions a directory called "images" which doesn't exist in the repo). Perhaps that file should be removed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've been slowly trying to prepare the libraries I use for GHC 9.0.
The libraries cryptonite and memory both depend on
basement, which has effectively been abandoned. Fortunately,hakylldoes not NEED those dependencies in my opinion.This PR removes those dependencies, which were used only for hashing.