don't require email address for feeds #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robx
commented
Oct 29, 2019
lib/Hakyll/Web/Feed.hs
Outdated
| @@ -120,6 +120,10 @@ renderFeed feedTpl itemTpl config itemContext items = do | |||
| StringField s -> return s | |||
| _ -> fail "Hakyll.Web.Feed.renderFeed: Internal error" | |||
|
|
|||
| emailField = case feedAuthorEmail config of | |||
| Nothing -> missingField | |||
| Just email -> constField "authorEmail" email | |||
There was a problem hiding this comment.
Would you prefer a new helper
optField : String -> Maybe String -> Context a
used as optField "authorEmail" (feedAuthorEmail config)?
puffnfresh
approved these changes
Dec 27, 2022
|
I'm generally fine with this idea but I've tried really hard to keep breaking changes at bay. Should we consider just using the empty string as empty? (I sort of hate the idea, but I also hate the idea of breaking everyone's blogs 😔) |
|
@jaspervdj sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I'm not sure this is the best way to do this, or it's even a good idea to make this optional, feel free to close.)
I found myself wanting to generate an atom.xml without providing an email address. According to RFC 4287, the
<email>tag is optional.This changes
feedAuthorEmailfromStringtoMaybe String, and updates the template accordingly.