Make url check concurrent #506
Conversation
|
I built the example site and added 50 external links from hacker news: Sample Markdown I ran the link checker against the sample site to see if these changes actually improved performance. I ran the link check 10 times with the concurrent link check and 10 times with master. The average time improved from 27.2 seconds to 20.5 seconds. Actual results: With concurrency: 13.882 average: 20.4602 Master (without concurrency): 17.040 average: 27.1793 |
|
I might also have time to add tests (we'll see) |
| #else | ||
| checkExternalUrl _ = return () | ||
| checkExternalUrl url = skip url Nothing |
There was a problem hiding this comment.
We do skip to make sure we eventually write to the MVar. Otherwise I believe that there's an error
|
Looks good to me 👍 (although I think this could be simplified a bit by just using an Can I merge this in or do you want to add additional work? |
|
Cool! (I didn't know what an You're welcome to merge this |
Resolves #479