Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing global tests #4000

Merged
merged 1 commit into from
Apr 5, 2016
Merged

Fix failing global tests #4000

merged 1 commit into from
Apr 5, 2016

Conversation

akre54
Copy link
Collaborator

@akre54 akre54 commented Mar 29, 2016

This should fix two of the failures in the test cases.

The other failure seems to be that in IE8 onhashchange is added to window. I'm not familiar enough with attachEvent (does it automatically create a global onhashchange?), but it seems that us calling Backbone.history.stop() isn't enough to remove the global. Anyone with IE experience care to shed some light?

There were a few other failures in https://travis-ci.org/jashkenas/backbone/builds/119075098 around default model attributes in IE8 too.

@akre54 akre54 mentioned this pull request Mar 29, 2016
Merged
@megawac megawac merged commit c8757f4 into jashkenas:master Apr 5, 2016
@megawac
Copy link
Collaborator

megawac commented Apr 5, 2016

@akre54 when you're trying to debug sauce failing in some browsers, create a branch on jashkenas/backbone so travis runs sauce

@megawac
Copy link
Collaborator

megawac commented Apr 5, 2016

Still 3 sauce failures post merge:
https://travis-ci.org/jashkenas/backbone/builds/120952966

@akre54
Copy link
Collaborator Author

akre54 commented Apr 5, 2016

create a branch on jashkenas/backbone so travis runs sauce

Good call.

Still 3 sauce failures

Right. One is the global onhashchange (does calling attachEvent('hashchange', fn) create the onhashchange for you? Should we delete that prop manually after the test?

The second two are IE8 defaults / prototype bugs. @jridgewell any thoughts?

@akre54 akre54 deleted the fix-globals branch April 5, 2016 18:49
@jridgewell
Copy link
Collaborator

This is issue with IE8 is overriding enumerability of properties that are non-enumerable (like #hasOwnProperty. The for-in loop won't traverse it, since it's "non-enumerable" in IE8. 😒

@akre54
Copy link
Collaborator Author

akre54 commented Apr 6, 2016 •
edited
Loading

Time to drop IE8 support? (no immediate changes, just no longer testing / edge case fixes for it)

@jridgewell
Copy link
Collaborator

That's fine with me.

@akre54
Copy link
Collaborator Author

akre54 commented Apr 6, 2016

#4008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akre54 @megawac @jridgewell