Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for urls in params. #3176

Merged
merged 1 commit into from
Jun 5, 2014
Merged

Add test for urls in params. #3176

merged 1 commit into from
Jun 5, 2014

Conversation

braddunbar
Copy link
Collaborator

Add test for #3175.

@braddunbar braddunbar mentioned this pull request Jun 4, 2014
Closed
akre54
akre54 reviewed Jun 5, 2014
View reviewed changes
.travis.yml
@@ -1,6 +1,5 @@
language: node_js
node_js:
- 0.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this separately, but yes 👍 on this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I'll pull it out. Thanks @akre54!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yanked and re-pulled in #3177.

akre54 added a commit that referenced this pull request Jun 5, 2014
@akre54
Merge pull request #3176 from braddunbar/url-param
b986d2b 
Add test for urls in params.
@akre54 akre54 merged commit b986d2b into jashkenas:master Jun 5, 2014
@braddunbar braddunbar deleted the url-param branch June 5, 2014 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braddunbar @akre54