Removing the IE8 PATCH requests fix #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Fine by me, though perhaps we should also document the version of jQuery we depend upon. |
akre54
added a commit
that referenced
this pull request
Jun 2, 2014
Removing the IE8 PATCH requests fix
|
Looks good by me. Glad jQuery finally came around. |
|
I agree with @braddunbar unless it is assumed that folks should be using the latest version of jQuery. Either way perhaps updating the main docs too along with this pr? |
Yes. Very important. |
|
It'll go out with the next release when this patch lands. Do we need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch requests were not working on IE8, even with the Backbone fix (tested on XP/IE8 with modern.ie VMs).
jQuery 1.11.* and the corresponding 2.x version now support PATCH requests (see: http://bugs.jquery.com/ticket/13240)
It now works as expected with jQuery