Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation paragraph for a common misconception about routes with trailing slashes. #2445

Merged
merged 1 commit into from
Mar 28, 2013

Conversation

alexmcpherson
Copy link
Contributor

Common enough issue with a good built in solution in optional matches in routes. I'd only discovered it in an old issue, so surfaced it to the docs. #848 (comment)

@jashkenas
Copy link
Owner

I guess we could add this ... but should we really be encouraging folks to junk up their urls with trailing slashes when it's really much nicer just to never mint them in the first place?

@alexmcpherson
Copy link
Contributor Author

Depends on the whole tone you want to documentation to take on I suppose. Docs can't fix everyone's bad web dev habits, but making the framework more accessible with friendly docs for common problems could be a good thing.

@jashkenas
Copy link
Owner

Well-argued, my friend.

jashkenas added a commit that referenced this pull request Mar 28, 2013
Documentation paragraph for a common misconception about routes with trailing slashes.
@jashkenas jashkenas merged commit 9c9463c into jashkenas:master Mar 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants