Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip trailing space in fragments. #1795

Merged
merged 3 commits into from
Nov 2, 2012
Merged

Strip trailing space in fragments. #1795

merged 3 commits into from
Nov 2, 2012

Conversation

braddunbar
Copy link
Collaborator

A continuation of #1794.

@djbriane
Copy link
Contributor

djbriane commented Nov 2, 2012

Brad -

Stripping trailing space is the approach I took in our code to fix the issue - so it definitely works (and is probably the safest way to fix the issue). The reason I took the approach of using getFragment is it seemed that when you do the comparison with checkUrl, it compares one string pulled from window.location with the fragment which has never been added to window.location. So if there were other weird things going on from the DOM side, you might get this issue again.

That being said, this looks like a proper way to fix the issue (and avoid any potential side effects of changing Backbone.history.navigate).

jashkenas added a commit that referenced this pull request Nov 2, 2012
Strip trailing space in fragments.
@jashkenas jashkenas merged commit 91ce6c3 into jashkenas:master Nov 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants