Fix #1653 - Ensure that History can be used outside of the browser.
#1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Dispense with options argument. * Use `window` to retrieve location/history by default. * Don't throw outside of the browser, allowing location and history to be replaced appropriately.
|
Looks like we need to cancel the travis integration on your fork in order to get the build errors to go away... |
jashkenas
added a commit
that referenced
this pull request
Sep 17, 2012
Fix #1653 - Ensure that `History` can be used outside of the browser.
|
@jashkenas Just turned it off. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windowto retrieve location/history by default.history to be replaced appropriately.