Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1173: (todo example) model ids are not properly indexed by collections on creation #1200

Merged
merged 1 commit into from
Apr 6, 2012
Merged

Issue 1173: (todo example) model ids are not properly indexed by collections on creation #1200

merged 1 commit into from
Apr 6, 2012

Conversation

ymichael
Copy link
Contributor

@ymichael ymichael commented Apr 6, 2012

the current create method modifies the model.idAttribute directly, causing the collection to be unaware of the change in idAttribute.

Changed to using model.set()

jashkenas added a commit that referenced this pull request Apr 6, 2012
@jashkenas
Merge pull request #1200 from ymichael/master
e2c5ce8 
Issue 1173: (todo example) model ids are not properly indexed by collections on creation
@jashkenas jashkenas merged commit e2c5ce8 into jashkenas:master Apr 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ymichael @jashkenas