Fix continuous reload loop when { hashChange: false } in IE <= 7 #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point. |
jashkenas
added a commit
that referenced
this pull request
Apr 6, 2012
Fix continuous reload loop when { hashChange: false } in IE <= 7
|
Thank you for fixing this @mostly-magic. You saved me from having to debug this infinite redirect bug in ie7! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you call
in IE <= 7, it creates the iframe to track history, and then calls
navigate.navigatechanges the window.location because of the hashChange option, and the window reloads and the process starts all over again.My solution is to completely bypass the iframe code when the option is set. There is no need to load the iframe code if not supporting the hashChange event.