proxy collection toJSON arguments to model #1098

troyk · 2012-03-14T10:07:50Z

I often pass arguments to a overridden toJSON method on the model for different views etc, but there is no support for this at the collection level, e.g.:

// to include a nested collection in the json
myCollection.toJSON({includeOwners:true});

The attached code changes the collection's toJSON to pass it's arguments like so:

// The JSON representation of a Collection is an array of the
// models' attributes.
toJSON: function() {
  var self_arguments = arguments;
  return this.map(function(model){ return model.toJSON.apply(model,self_arguments); });
}

tests included. --thanks, troy

jashkenas · 2012-03-14T14:27:27Z

Good idea -- but I don't think we need to formalize the API quite like that. Let's just pass along an options object.

troyk · 2012-03-14T17:19:10Z

@jashkenas Thanks for getting this in so quick, I went the apply route to keep the api informal allowing both toJSON(arg1, arg2, ..) and toJSON({ .. })

proxy collection toJSON arguments to model

c2b337e

jashkenas closed this in 9414513 Mar 14, 2012

vincentbriglia mentioned this pull request Apr 16, 2012

model.toJSON and collection.toJSON unused options argument #1222

Closed

braddunbar mentioned this pull request Jun 14, 2012

toJSON function's parameter misleading #1410

Closed

paulfalgout mentioned this pull request Dec 2, 2014

Proposed simplification of serializeData marionettejs/backbone.marionette#2094

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

proxy collection toJSON arguments to model #1098

proxy collection toJSON arguments to model #1098

troyk commented Mar 14, 2012

jashkenas commented Mar 14, 2012

troyk commented Mar 14, 2012

proxy collection toJSON arguments to model #1098

proxy collection toJSON arguments to model #1098

Conversation

troyk commented Mar 14, 2012

jashkenas commented Mar 14, 2012

troyk commented Mar 14, 2012