Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add Lo-Dash to the docs. #2452

Closed
jdalton opened this issue Apr 1, 2013 · 6 comments
Closed

Re-add Lo-Dash to the docs. #2452

jdalton opened this issue Apr 1, 2013 · 6 comments
Labels
fixed

Comments

@jdalton
Copy link
Contributor

jdalton commented Apr 1, 2013

With Backbone's bump to v1.0.0 Lo-Dash was removed from the docs.

I'm not sure why it was removed since, unlike jQuery and Zepto, Lo-Dash ships with, and tests against, Backbone's unit tests. It also maintains compat builds, even in cdnjs, specifically for compat with Underscore/Backbone.

This also seems to come as a surprise to other Backbone contributors.

lodash underscore build

lodash backbone build
@jdalton
Copy link
Contributor Author

jdalton commented Apr 1, 2013

For reference #1713 that got it included in the docs.

jdalton referenced this issue Apr 1, 2013
@jashkenas
Backbone.js 1.0
699fe32
@phated
Copy link

phated commented Apr 1, 2013

+1 for this. There is no need to remove the lodash, since it puts all the effort into being underscore compatible.

@AjaxSolutions
Copy link

+1 Lo-Dash and Backbone work well together (used both on a large application)

@gbouthenot
Copy link

+1
If the removal was done on purpose, it should have provided the reason.

@wookiehangover
Copy link
Collaborator

I think that calling out Lo-dash has a place in the documentation, but probably in the FAQ under the heading "Alternate Dependencies."

It seems like that's the a potential outcome in #2431, at least.

@jdalton
Copy link
Contributor Author

jdalton commented Apr 2, 2013

@wookiehangover
Some mention is better than none, though I gotta say I don't dig being lumped in with a "use at your own risk" lib like Zepto, especially when Lo-Dash goes above and beyond even Underscore* in terms of compatibility.

* Underscore v1.4.4 broke compat, with versions of Backbone, in _.bind & edge is doing so with _.bindAll too

jashkenas added a commit that referenced this issue Apr 4, 2013
@jashkenas
Fixes #2431, #2452, a little bit lex talionis, but appropriate, I think.
afb9dfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jdalton @jashkenas @wookiehangover @AjaxSolutions @phated @gbouthenot