Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On-finished weird behaviours #51

Closed
AndreaCrotti opened this issue Jun 30, 2021 · 1 comment
Closed

On-finished weird behaviours #51

AndreaCrotti opened this issue Jun 30, 2021 · 1 comment

Comments

@AndreaCrotti
Copy link

AndreaCrotti commented Jun 30, 2021 •
edited
Loading

I can reproduce a behaviour that I think is weird with something like

(chime/chime-at
  [10 20 30]
  (fn [time] (println time))
  {:on-finished (fn [] (println "one") (Thread/sleep 100) (println "two"))})

And what happens is that the one gets printed but two never does.
@jarohen
Copy link
Owner

jarohen commented Jun 30, 2021 •
edited
Loading

Cheers @AndreaCrotti, fix on master, and 0.3.4-SNAPSHOT released

jarohen added a commit that referenced this issue Jun 30, 2021
@jarohen
don't pull the rug out from underneath on-finished - fixes #51, cheers …
975da72 
…@AndreaCrotti
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreaCrotti @jarohen