Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop times that have already passed #48

Closed
werenike opened this issue Mar 14, 2021 · 1 comment
Closed

Drop times that have already passed #48

werenike opened this issue Mar 14, 2021 · 1 comment

Comments

@werenike
Copy link

werenike commented Mar 14, 2021

In one of the examples in the README, it says: "Any times that have already passed will be dropped, as before" and this is the behavior that I would like in my application. However it seems that this is not the case: if I pass a time in the past to chime-at, the function is immediately executed with that time. For example:

(chime/chime-at [(.minus (Instant/now) 1 (ChronoUnit/HOURS))] println)

This prints immediately with the time an hour in the past.

My solution for now is to manually drop input times in the past, but I'm interested to hear whether I'm misunderstanding the example text, or something else is going on.

@jarohen
Copy link
Owner

jarohen commented Mar 16, 2021

Thanks for spotting this - this was in fact a breaking change a few releases ago. Will update the README :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants