-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] upgrades html-minifier-terser@5.0.0 -> 6.0.2 #1688
[chore] upgrades html-minifier-terser@5.0.0 -> 6.0.2 #1688
Conversation
@jantimon I will have a follow up PR to make these fixtures snapshots as this would have been easier to run |
You can rebuild all examples with Snapshots are way harder to read |
I will run that to make sure I got everything! @jantimon Is there anything else I should do before we can merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need async await to return the promise.
Can you please revert those two changes?
@gabrielcsapo did you already have time to look into my feedback? :) |
Co-authored-by: Jan Nicklas <j.nicklas@me.com>
Co-authored-by: Jan Nicklas <j.nicklas@me.com>
@jantimon just updated the PR based on the feedback. |
@jantimon kindly bumping this. |
thanks @gabrielcsapo |
released as 5.4.0 |
@gabrielcsapo your changes break the build pipelines - could you please take a look what’s wrong? |
Yes, I’ll check today.
…On Sat, Oct 16, 2021 at 1:42 AM Jan Nicklas ***@***.***> wrote:
@gabrielcsapo <https://github.com/gabrielcsapo> your changes break the
build pipelines - could you please take a look what’s wrong?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1688 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOE2WYFTRFGWVZ2ILABIOLUHE3ITANCNFSM5FAXH7LA>
.
|
@jantimon there seems to be a race condition with checking the contents of the files on disk and starting a new test. It might make sense to have each test output to a specific directory on disk to avoid collisions. I am not seeing this same issue locally, so it will be hard to debug to be for sure. Another option is using snapshots as they are in memory and won't have collision issues. |
Summary
fixes #1687.
Updates the snapshots to reflect the terser upgrade.