-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missings typings
property in package.json
in beta
#1108
Comments
Actually, the typings you are shipping seem to be incorrect in general as you are not exporting the class instance correctly. |
Could you please be a little bit more concrete? |
Compare https://github.com/jantimon/html-webpack-plugin/blob/master/typings.d.ts with https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/html-webpack-plugin/index.d.ts The typings shipped with this package are mostly useless without the class export. |
Or we can rename typings.d.ts to index.d.ts according to https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html |
Adding a |
But we don’t export the typings - we use the typescript salsa feature jsdocs as typings. The typings.d.ts is just an internal helper for the html-webpack-plugin. However the typescript team is working on generating definition files from salsa files. Once that works we will provide a typing file which we will link from the package.json to the type file |
The main idea was to prevent bugs by using types from webpack. If the changes you did on #1132 are enough to provide external typings then I am happy to make them public as |
Expected behaviour
Types load correctly.
Current behaviour
Types do not load.
Environment
Latest TS version on node 10.12.
Config
Relevant Links
https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html
The text was updated successfully, but these errors were encountered: