Assemble multiple PDUs from a single buffer #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you should test that the TCP use case is not affected. seems maybe for tcp you need to give the single pdu. line 185 |
|
@geynis Do you have any leftover pcaps from May? I am lazy, and would rather not create any myself `:D |
|
please rebase over develop branch |
geynis
reviewed
Sep 22, 2019
someip.lua
Outdated
| end | ||
|
|
||
| -- Return next SOMEIP packet -- |
There was a problem hiding this comment.
you should redesign, such that this dissector will call itself as a new protocol layer.
TomerShalish
force-pushed
the
feature/assemble-multiple-pdus
branch
4 times, most recently
from
73a1a92 to
713cd48
Compare
TomerShalish
force-pushed
the
feature/assemble-multiple-pdus
branch
from
713cd48 to
296f463
Compare
geynis
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.