Support for multiple users and API keys #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Are you using this code in a test or production environment? |
…real names. Removed an unnecessary log.
|
I'm not sure what you mean... I have it deployed to heroku for free (1 dyno), but I am using it for GitHub/Asana integration at my company, on our actual repos/projects. If you were just asking because of the console.log statement, I removed that :) I also just fixed an error in my documentation. The |
|
Yes I meant whether you were running it successfully. Thanks for the feedback. I will merge the change in. |
jamieforrest
added a commit
that referenced
this pull request
Oct 14, 2013
Support for multiple users and API keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow comments to appear from individual developers. If the author is not found in the ASANA_USERS variable, the ASANA_KEY will be used. As described in the updated
README.md, the ASANA_USERS variable is formatted as:[{"username":"FirstName LastName", "key":"XXXXXXXX.XXXXXXXXXXXXXXXXXX"}, {"username":"FirstName2 LastName2", "key":"XXXXXXXX.XXXXXXXXXXXXXXXXXX"}]This resolves #7 and is based on work by @LarsHassler (LarsHassler@1399ea8)
I haven't done much with javascript, so let me know if you see any issues with this.