Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Update v1 query service to check for adapter at construction #6482

Merged
merged 2 commits into from
Jan 4, 2025
Merged

[query] Update v1 query service to check for adapter at construction #6482

merged 2 commits into from
Jan 4, 2025
+21 −78

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • This PR changes the v1 query service to check for the v1 adapter at construction rather than at method invocation.
  • Currently, the constructor will panic if its provided a native v2 storage implementation. This will be remedied in a follow-up PR that will implement a reverse adapter to go from v2->v1.

How was this change tested?

  • CI and added a unit test

Checklist

@mahadzaryab1
Change v1 Query Service To Hold spanstore.Reader
f528243 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Add Test For Panic Error
0b04f42 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner January 4, 2025 16:20
@dosubot dosubot bot added the area/storage label Jan 4, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (f91822b) to head (0b04f42).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6482      +/-   ##
==========================================
+ Coverage   96.27%   96.29%   +0.02%     
==========================================
  Files         370      370              
  Lines       21182    21170      -12     
==========================================
- Hits        20393    20386       -7     
+ Misses        604      600       -4     
+ Partials      185      184       -1
Flag Coverage Δ
badger_v1 10.75% <0.00%> (+0.01%) ⬆️
badger_v2 2.80% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1-manual 16.64% <0.00%> (+0.01%) ⬆️
cassandra-4.x-v2-auto 2.73% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v2-manual 2.73% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v1-manual 16.64% <0.00%> (+0.01%) ⬆️
cassandra-5.x-v2-auto 2.73% <0.00%> (+<0.01%) ⬆️
cassandra-5.x-v2-manual 2.73% <0.00%> (+<0.01%) ⬆️
elasticsearch-6.x-v1 20.34% <0.00%> (+0.02%) ⬆️
elasticsearch-7.x-v1 20.41% <0.00%> (+0.03%) ⬆️
elasticsearch-8.x-v1 20.56% <0.00%> (+0.01%) ⬆️
elasticsearch-8.x-v2 2.79% <0.00%> (+<0.01%) ⬆️
grpc_v1 12.40% <0.00%> (+<0.01%) ⬆️
grpc_v2 9.16% <0.00%> (+0.01%) ⬆️
kafka-3.x-v1 10.59% <0.00%> (+0.01%) ⬆️
kafka-3.x-v2 2.80% <0.00%> (+<0.01%) ⬆️
memory_v2 2.80% <0.00%> (+<0.01%) ⬆️
opensearch-1.x-v1 20.46% <0.00%> (+0.02%) ⬆️
opensearch-2.x-v1 20.45% <0.00%> (+0.01%) ⬆️
opensearch-2.x-v2 2.79% <0.00%> (+<0.01%) ⬆️
tailsampling-processor 0.52% <0.00%> (+<0.01%) ⬆️
unittests 95.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 59b544a into jaegertracing:main Jan 4, 2025
56 checks passed
@mahadzaryab1 mahadzaryab1 deleted the update-v1-querysvc branch January 6, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
area/storage changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahadzaryab1 @yurishkuro