Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Storage v2 API to use streaming #6359

Merged
merged 5 commits into from
Dec 14, 2024
Merged

Change Storage v2 API to use streaming #6359

merged 5 commits into from
Dec 14, 2024
+323 −152

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 14, 2024 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Change tracestore.Reader interface to use function iterators in the style of Go 1.23 iter package
  • Add a sort of a backport of iter package until we can upgrade to Go 1.23

How was this change tested?

  • CI

@yurishkuro
Change Storage v2 API to use streaming
fb98d0a 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 14, 2024 02:11
@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Dec 14, 2024
@yurishkuro
fix
6f68393 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
fix
7920cb8 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.14%. Comparing base (9eb0170) to head (c2cc13e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6359      +/-   ##
==========================================
- Coverage   96.14%   96.14%   -0.01%     
==========================================
  Files         357      358       +1     
  Lines       20355    20391      +36     
==========================================
+ Hits        19571    19604      +33     
- Misses        599      601       +2     
- Partials      185      186       +1
Flag Coverage Δ
badger_v1 8.98% <0.00%> (-0.04%) ⬇️
badger_v2 1.63% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 14.96% <0.00%> (-0.06%) ⬇️
cassandra-4.x-v2-auto 1.57% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 1.57% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 14.96% <0.00%> (-0.06%) ⬇️
cassandra-5.x-v2-auto 1.57% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 1.57% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 18.64% <0.00%> (-0.07%) ⬇️
elasticsearch-7.x-v1 18.72% <0.00%> (-0.08%) ⬇️
elasticsearch-8.x-v1 18.89% <0.00%> (-0.07%) ⬇️
elasticsearch-8.x-v2 1.62% <0.00%> (-0.02%) ⬇️
grpc_v1 10.48% <0.00%> (-0.05%) ⬇️
grpc_v2 7.92% <0.00%> (-0.03%) ⬇️
kafka-v1 9.30% <0.00%> (-0.04%) ⬇️
kafka-v2 1.63% <0.00%> (-0.01%) ⬇️
memory_v2 1.63% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 18.77% <0.00%> (-0.07%) ⬇️
opensearch-2.x-v1 18.76% <0.00%> (-0.08%) ⬇️
opensearch-2.x-v2 1.62% <0.00%> (-0.02%) ⬇️
tailsampling-processor 0.45% <0.00%> (-0.01%) ⬇️
unittests 95.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member Author

@mahadzaryab1 can you review?

mahadzaryab1
mahadzaryab1 reviewed Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments / questions

pkg/iter/iter.go Show resolved Hide resolved
pkg/iter/iter_test.go Show resolved Hide resolved
pkg/iter/iter.go Show resolved Hide resolved
storage_v2/factoryadapter/reader.go Show resolved Hide resolved
storage_v2/tracestore/reader.go Outdated Show resolved Hide resolved
storage_v2/tracestore/reader.go Outdated Show resolved Hide resolved
storage_v2/tracestore/reader.go Outdated Show resolved Hide resolved
storage_v2/tracestore/reader.go Outdated Show resolved Hide resolved
@yurishkuro
Improve comments, remove NotFound error
debe54a 
Signed-off-by: Yuri Shkuro <github@ysh.us>
mahadzaryab1
mahadzaryab1 approved these changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

storage_v2/tracestore/reader.go Outdated Show resolved Hide resolved
@yurishkuro @mahadzaryab1
Update storage_v2/tracestore/reader.go
c2cc13e 
Co-authored-by: Mahad Zaryab <43658574+mahadzaryab1@users.noreply.github.com>
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@yurishkuro yurishkuro enabled auto-merge (squash) December 14, 2024 21:46
@yurishkuro yurishkuro merged commit c6fa1af into jaegertracing:main Dec 14, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahadzaryab1 mahadzaryab1 mahadzaryab1 approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/storage changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurishkuro @mahadzaryab1