Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use real metrics factory instead of NullFactory #6261

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Use real metrics factory instead of NullFactory #6261

merged 1 commit into from
Nov 26, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Some components were still using metrics.NullFactory

Description of the changes

  • Create real factory from OTEL MetricsProvider

How was this change tested?

  • CI

@yurishkuro
Use real metrics factory instead of NullFactory
50b1922 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner November 26, 2024 16:41
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (600d82c) to head (50b1922).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6261      +/-   ##
==========================================
- Coverage   96.44%   96.41%   -0.03%     
==========================================
  Files         355      355              
  Lines       20155    20156       +1     
==========================================
- Hits        19438    19434       -4     
- Misses        528      532       +4     
- Partials      189      190       +1
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.85% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.67% <ø> (+<0.01%) ⬆️
grpc_v1 9.43% <ø> (-0.01%) ⬇️
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.66% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.73% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.33% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 16e964d into jaegertracing:main Nov 26, 2024
53 checks passed
@yurishkuro yurishkuro deleted the remove-null-factory branch November 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahadzaryab1 mahadzaryab1 mahadzaryab1 approved these changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurishkuro @mahadzaryab1