Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use confighttp in expvar extension #6227

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Use confighttp in expvar extension #6227

merged 7 commits into from
Nov 21, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • expvar extension configuration was using non-standard config that did not allow specifying host to listen to

Description of the changes

  • Change it to use OTEL helper

How was this change tested?

  • go run ./cmd/jaeger
  • curl http://localhost:27777

@yurishkuro
Use confighttp in expvar extension
da3cbbd 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
fix
520702d 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner November 20, 2024 02:24
@yurishkuro yurishkuro requested a review from jkowall November 20, 2024 02:24
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.42%. Comparing base (48cf1ba) to head (5e7b07b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/jaeger/internal/extension/expvar/extension.go 80.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6227      +/-   ##
==========================================
- Coverage   96.45%   96.42%   -0.03%     
==========================================
  Files         355      355              
  Lines       20157    20167      +10     
==========================================
+ Hits        19442    19446       +4     
- Misses        528      532       +4     
- Partials      187      189       +2
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (ø)
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v2 1.66% <ø> (ø)
grpc_v1 9.44% <ø> (ø)
grpc_v2 6.97% <ø> (-0.01%) ⬇️
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.66% <ø> (-0.01%) ⬇️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.33% <83.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

yurishkuro and others added 5 commits November 19, 2024 21:41
@yurishkuro
fix-logging
b4bc48b 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
Merge branch 'main' into expvar
52094cf
@yurishkuro
Merge branch 'main' into expvar
f425f55
@yurishkuro
fix
2df58e4 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
add test
5e7b07b 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit f43870b into jaegertracing:main Nov 21, 2024
51 of 52 checks passed
@yurishkuro yurishkuro deleted the expvar branch November 21, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahadzaryab1 mahadzaryab1 mahadzaryab1 approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurishkuro @mahadzaryab1