Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect environment variables when creating internal tracer #6179

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Respect environment variables when creating internal tracer #6179

merged 3 commits into from
Nov 11, 2024

Conversation

akstron
Copy link
Contributor

@akstron akstron commented Nov 8, 2024 •
edited
Loading

Which problem is this PR solving?

Resolves #6122

Description of the changes

  • The changes include using the otlptracegrpc.WithInsecure() based on OTEL_EXPORTER_OTLP_ENDPOINT and OTEL_EXPORTER_OTLP_INSECURE env variables.

Checklist

@akstron
Added default Insecure option based on env variables
e30a0e7 
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
@akstron akstron requested a review from a team as a code owner November 8, 2024 15:53
@akstron akstron requested a review from joe-elliott November 8, 2024 15:53
@dosubot dosubot bot added the area/otel label Nov 8, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (a420fd9) to head (c65b4be).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6179      +/-   ##
==========================================
+ Coverage   96.47%   96.49%   +0.01%     
==========================================
  Files         354      354              
  Lines       20126    20132       +6     
==========================================
+ Hits        19417    19426       +9     
+ Misses        524      522       -2     
+ Partials      185      184       -1
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.84% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.67% <ø> (+0.01%) ⬆️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.00% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.66% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.73% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.72% <ø> (ø)
opensearch-2.x-v2 1.66% <ø> (-0.02%) ⬇️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.40% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akstron
Copy link
Contributor Author

akstron commented Nov 8, 2024

I ran the failing Build all-in-one / all-in-one (v1) (pull_request) without my changes, but it still fails for getAPITrace and getServicesAPIV3

@akstron
Minor fix
58d01b2 
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
yurishkuro
yurishkuro reviewed Nov 11, 2024
View reviewed changes
pkg/jtracer/jtracer.go Outdated Show resolved Hide resolved
@akstron
Improved if condition
c65b4be 
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
@yurishkuro yurishkuro changed the title Add GRPC Options Based on Env Variables Respect environment variables when creating internal tracer Nov 11, 2024
@yurishkuro yurishkuro merged commit e2067ef into jaegertracing:main Nov 11, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/otel changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Jaeger Query Should Accept Configurable Jaeger Collector Address when enabled query.enable-tracing
2 participants
@akstron @yurishkuro