[jaeger-v2] Implement UTF-8 sanitizer for OTLP #6078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
commented
Oct 12, 2024
Comment on lines
96
to
97
| default: | ||
| sanitized = append(sanitized, []byte(v.Str())...) |
There was a problem hiding this comment.
I'd like to get a second set of eyes on this. In v1, we casted the value to a lossy string and converted it to its byte representation. Is just doing v.str() safe here?
There was a problem hiding this comment.
Write unit tests for different types and we will found out.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6078 +/- ##
=======================================
Coverage 96.92% 96.93%
=======================================
Files 351 352 +1
Lines 16675 16720 +45
=======================================
+ Hits 16162 16207 +45
Misses 329 329
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Oct 12, 2024
Comment on lines
96
to
97
| default: | ||
| sanitized = append(sanitized, []byte(v.Str())...) |
There was a problem hiding this comment.
Write unit tests for different types and we will found out.
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
commented
Oct 12, 2024
|
|
||
| for k, v := range invalidKeys { | ||
| sanitized := []byte(k + ":") | ||
| switch v.Type() { |
There was a problem hiding this comment.
From the godoc of Type()
// Type returns the type of the value for this Value.
// Calling this function on zero-initialized Value will cause a panic.Can we run into a situation where we call this on a zero-initialized value in the regular exporter flow?
There was a problem hiding this comment.
In theory, but I think we wouldn't reach that point.
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
yurishkuro
reviewed
Oct 13, 2024
| } | ||
|
|
||
| attributes.Remove(k) | ||
| newVal := attributes.PutEmptyBytes(invalidTagKey) |
There was a problem hiding this comment.
What happens if we have two attributes with invalid keys?
There was a problem hiding this comment.
thanks for flagging! added in a bit to enumerate the keys - let me know what you think
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
force-pushed
the
utf8-sanitizer
branch
from
bcc0f2b to
a6d0429
Compare
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
mahadzaryab1
force-pushed
the
utf8-sanitizer
branch
from
829c688 to
91d02c2
Compare
yurishkuro
added
the
changelog:exprimental
yurishkuro
approved these changes
Oct 14, 2024
chahatsagarmain
pushed a commit
to chahatsagarmain/jaeger
that referenced
this pull request
Oct 23, 2024
## Which problem is this PR solving? - Resolves jaegertracing#5545 ## Description of the changes - Continuation of jaegertracing#6077 to implement the UTF-8 sanitizer to operate on OTLP data. ## How was this change tested? - Unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test