-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Add legacy formats into e2e kafka integration tests #5824
Conversation
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5824 +/- ##
=======================================
Coverage 96.79% 96.79%
=======================================
Files 342 342
Lines 16523 16523
=======================================
Hits 15994 15994
Misses 341 341
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ncoding Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised this works without changing the topic name for each test - doesn't it create a conflict with the same topic used for different data format?
Yeah, my next plan would be to generate random topic names to avoid any future conflicts but most probably the reason why it's not throwing up errors is that the tests are not running in parallel, there's no overlap in the reading and writing of messages to the Kafka topic. I'm assuming our sequential execution ensures that the data format in the topic aligns with the format expected by the test. |
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Signed-off-by: joeyyy09 <menteharshith@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code mostly looks good, any idea why it's failing? It was not clear from the run's logs.
Not sure why the test fails at this point, I'll try to debug and see if I can get something from the logs. Else, I'll revisit the code and come up with a different logic or approach. |
The Jaeger thrift and OTLP JSON for some reason fail, from the logs can say that the v2 binary refuses to start. So I'm assuming that there's something off with the configs or maybe the formats aren't supported the way we've been trying to use. I'll see if I can come up with something more accurate. |
…ng#5824) ## Description of the changes - Add Kafka tests for legacy Jaeger formats, because people migrating from v1 are not able to start using otlp in v1 ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: joeyyy09 <menteharshith@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Description of the changes
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test