Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Enable remote sampling extension and include in e2e tests #5802

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[v2] Enable remote sampling extension and include in e2e tests #5802

merged 1 commit into from
Aug 5, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Aug 5, 2024 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Enable remote sampling extension in v2 all-in-one configuration
  • Fix Dockerfile to copy this into the image in the appropriate location
  • Change the default ports for the extension to match OTEL & agent 5778/5779
  • Re-enable sampling e2e tests for v2 all-in-one

How was this change tested?

  • make all-in-one-integration-test
  • CI

@yurishkuro
[v2] Enable remote sampling extension and include in e2e tests
c95a90e 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added v2 changelog:exprimental Change to an experimental part of the code labels Aug 5, 2024
@yurishkuro yurishkuro requested a review from a team as a code owner August 5, 2024 04:24
@yurishkuro yurishkuro requested a review from jkowall August 5, 2024 04:24
@dosubot dosubot bot added area/sampling docker Pull requests that update Docker code labels Aug 5, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (8afda31) to head (c95a90e).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5802   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files         342      342           
  Lines       16520    16521    +1     
=======================================
+ Hits        15969    15970    +1     
  Misses        362      362           
  Partials      189      189
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.81% <ø> (-0.01%) ⬇️
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.74% <ø> (-0.01%) ⬇️
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (-0.01%) ⬇️
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.02% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.81% <ø> (-0.01%) ⬇️
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.14% <ø> (-0.01%) ⬇️
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.81% <ø> (-0.01%) ⬇️
memory_v2 1.81% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.89% <ø> (ø)
opensearch-2.x-v1 18.89% <ø> (ø)
opensearch-2.x-v2 1.80% <ø> (-0.02%) ⬇️
unittests 95.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jkowall
jkowall approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yurishkuro yurishkuro merged commit b76dc65 into jaegertracing:main Aug 5, 2024
49 checks passed
@yurishkuro yurishkuro deleted the fix5531 branch August 5, 2024 19:07
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 7, 2024
@yurishkuro @JaredTan95
[v2] Enable remote sampling extension and include in e2e tests (jaege…
7e584f1 
…rtracing#5802)

## Which problem is this PR solving?
- Resolves jaegertracing#5531

## Description of the changes
- Enable remote sampling extension in v2 all-in-one configuration
- Fix Dockerfile to copy this into the image in the appropriate location
- Change the default ports for the extension to match OTEL & agent
5778/5779
- Re-enable sampling e2e tests for v2 all-in-one

## How was this change tested?
- `make all-in-one-integration-test`
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 8, 2024
@yurishkuro @JaredTan95
[v2] Enable remote sampling extension and include in e2e tests (jaege…
ca2650a 
…rtracing#5802)

## Which problem is this PR solving?
- Resolves jaegertracing#5531

## Description of the changes
- Enable remote sampling extension in v2 all-in-one configuration
- Fix Dockerfile to copy this into the image in the appropriate location
- Change the default ports for the extension to match OTEL & agent
5778/5779
- Re-enable sampling e2e tests for v2 all-in-one

## How was this change tested?
- `make all-in-one-integration-test`
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 13, 2024
@yurishkuro @JaredTan95
[v2] Enable remote sampling extension and include in e2e tests (jaege…
38b8922 
…rtracing#5802)

## Which problem is this PR solving?
- Resolves jaegertracing#5531

## Description of the changes
- Enable remote sampling extension in v2 all-in-one configuration
- Fix Dockerfile to copy this into the image in the appropriate location
- Change the default ports for the extension to match OTEL & agent
5778/5779
- Re-enable sampling e2e tests for v2 all-in-one

## How was this change tested?
- `make all-in-one-integration-test`
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 14, 2024
@yurishkuro @JaredTan95
[v2] Enable remote sampling extension and include in e2e tests (jaege…
0e00194 
…rtracing#5802)

## Which problem is this PR solving?
- Resolves jaegertracing#5531

## Description of the changes
- Enable remote sampling extension in v2 all-in-one configuration
- Fix Dockerfile to copy this into the image in the appropriate location
- Change the default ports for the extension to match OTEL & agent
5778/5779
- Re-enable sampling e2e tests for v2 all-in-one

## How was this change tested?
- `make all-in-one-integration-test`
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
@yurishkuro yurishkuro mentioned this pull request Aug 16, 2024
Merged
4 tasks
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 28, 2024
@yurishkuro @JaredTan95
[v2] Enable remote sampling extension and include in e2e tests (jaege…
bf5c124 
…rtracing#5802)

## Which problem is this PR solving?
- Resolves jaegertracing#5531

## Description of the changes
- Enable remote sampling extension in v2 all-in-one configuration
- Fix Dockerfile to copy this into the image in the appropriate location
- Change the default ports for the extension to match OTEL & agent
5778/5779
- Re-enable sampling e2e tests for v2 all-in-one

## How was this change tested?
- `make all-in-one-integration-test`
- CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall jkowall approved these changes

Assignees
No one assigned
Labels
area/sampling changelog:exprimental Change to an experimental part of the code docker Pull requests that update Docker code v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[jaeger-v2] Support sampling strategies
2 participants
@yurishkuro @jkowall