-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - do not merge - Grpc archive storage rebase #2505
Closed
yurishkuro
wants to merge
25
commits into
jaegertracing:master
from
yurishkuro:grpc-archive-storage-rebase
Closed
WIP - do not merge - Grpc archive storage rebase #2505
yurishkuro
wants to merge
25
commits into
jaegertracing:master
from
yurishkuro:grpc-archive-storage-rebase
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Migrate from ArchiveSupportedRequest to CapabilitiesRequest Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
…ces on plugin client side Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
- make internal types private - add interface validations - wrap errors with %w Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Andrew Putilov <to.merge@gmail.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying the CI for #2317 rebased from master, to see how code coverage is affected.