Closed
Description
Requirement
In this issue, we want to align the configuration for the query service with OTEL (part of #5229)
Tasks / outcomes
- All config fields are tagged with mapstructure such that they can be addressable from YAML via "good" namesConfigs implement Validate()Configs via YAML support the same defaults as in jaeger-v1Configs reuse standard elements of OTEL configs whenever possible, e.g. TLS, clientcfg, etc.Configuration looks "logical" and properly grouped, not flattened with long weird namesWe create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields
Activity
[jaeger-v2] Refactor Configuration For Query Service (#5998)
yurishkuro commentedon Sep 25, 2024
this box is checked, is it correct?
mahadzaryab1 commentedon Sep 25, 2024
@yurishkuro The migration guide is linked in the PR description. Is that what you were asking? Let me know if I misunderstood.
mahadzaryab1 commentedon Sep 25, 2024
@yurishkuro Should we do the migration for v1 to OTEL HTTP/GRPC configurations as part of this issue?
yurishkuro commentedon Sep 25, 2024
Sorry, not seeing migration guide.
On migrating servers - would be nice, minimize the differences. But ok to leave as is too.
mahadzaryab1 commentedon Sep 25, 2024
@yurishkuro Here it is. It was linked in the PR. My apologies if it wasn't very visible.
mahadzaryab1 commentedon Sep 25, 2024
@yurishkuro It looks pretty doable for the most part. There's just one part that isn't super compatible.
AdditionalHeaders
in v1 is of typemap[string][]string
. On the other hand,ResponseHeaders
is of typemap[string]configopaque.String
. Do you have any thoughts on this and if there's a way to consolidate them?yurishkuro commentedon Sep 25, 2024
We can converge to OTEL ones. I doubt if our cli actually allows to specify []string for each header.
yurishkuro commentedon Sep 25, 2024
Thanks, I copied the migration guide to a document I own https://docs.google.com/document/d/1ydTrEtIqJZxGb0RBkUAW-ZIaHNijo1pZSrn1TDSK-LU/edit#
mahadzaryab1 commentedon Sep 25, 2024
No worries! I've done the same for the rest of the PRs in case you wanted to copy those over as well.
12 remaining items