Skip to content

[jaeger-v2] Align Query Service Config With OTEL #5996

Closed
@mahadzaryab1

Description

Requirement

In this issue, we want to align the configuration for the query service with OTEL (part of #5229)

Tasks / outcomes

  • All config fields are tagged with mapstructure such that they can be addressable from YAML via "good" names
    Configs implement Validate()
    Configs via YAML support the same defaults as in jaeger-v1
    Configs reuse standard elements of OTEL configs whenever possible, e.g. TLS, clientcfg, etc.
    Configuration looks "logical" and properly grouped, not flattened with long weird names
    We create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields

Activity

yurishkuro

yurishkuro commented on Sep 25, 2024

@yurishkuro
Member

We create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields

this box is checked, is it correct?

mahadzaryab1

mahadzaryab1 commented on Sep 25, 2024

@mahadzaryab1
CollaboratorAuthor

We create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields

this box is checked, is it correct?

@yurishkuro The migration guide is linked in the PR description. Is that what you were asking? Let me know if I misunderstood.

mahadzaryab1

mahadzaryab1 commented on Sep 25, 2024

@mahadzaryab1
CollaboratorAuthor

@yurishkuro Should we do the migration for v1 to OTEL HTTP/GRPC configurations as part of this issue?

yurishkuro

yurishkuro commented on Sep 25, 2024

@yurishkuro
Member

Sorry, not seeing migration guide.

On migrating servers - would be nice, minimize the differences. But ok to leave as is too.

mahadzaryab1

mahadzaryab1 commented on Sep 25, 2024

@mahadzaryab1
CollaboratorAuthor

Sorry, not seeing migration guide.

@yurishkuro Here it is. It was linked in the PR. My apologies if it wasn't very visible.

mahadzaryab1

mahadzaryab1 commented on Sep 25, 2024

@mahadzaryab1
CollaboratorAuthor

On migrating servers - would be nice, minimize the differences. But ok to leave as is too.

@yurishkuro It looks pretty doable for the most part. There's just one part that isn't super compatible. AdditionalHeaders in v1 is of type map[string][]string. On the other hand, ResponseHeaders is of type map[string]configopaque.String. Do you have any thoughts on this and if there's a way to consolidate them?

yurishkuro

yurishkuro commented on Sep 25, 2024

@yurishkuro
Member

We can converge to OTEL ones. I doubt if our cli actually allows to specify []string for each header.

yurishkuro

yurishkuro commented on Sep 25, 2024

@yurishkuro
Member

It was linked in the PR. My apologies if it wasn't very visible.

Thanks, I copied the migration guide to a document I own https://docs.google.com/document/d/1ydTrEtIqJZxGb0RBkUAW-ZIaHNijo1pZSrn1TDSK-LU/edit#

mahadzaryab1

mahadzaryab1 commented on Sep 25, 2024

@mahadzaryab1
CollaboratorAuthor

It was linked in the PR. My apologies if it wasn't very visible.

Thanks, I copied the migration guide to a document I own https://docs.google.com/document/d/1ydTrEtIqJZxGb0RBkUAW-ZIaHNijo1pZSrn1TDSK-LU/edit#

No worries! I've done the same for the rest of the PRs in case you wanted to copy those over as well.

12 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      [jaeger-v2] Align Query Service Config With OTEL · Issue #5996 · jaegertracing/jaeger