Add parameter to include the current project in the aggregated report #1007

lion7 · 2020-01-30T12:58:15Z

This PR tries to solve the issue described in #812.
It is similar to #430, #680 and #970 but with the #680 (comment) of @marchof and #812 (comment) of @Godin taken into account.

ramachandranms · 2020-02-21T16:56:08Z

@marchof, @Godin

gentle bump, if this has fallen through cracks. would be great to have this feature as the workarounds are not easier to understand and get through. greatly appreciate a review to merge this. thanks in advance.

pertsodian · 2020-03-20T05:42:57Z

Hi @marchof & @Godin, can we please review this PR? I think there are already quite a number of requests for this feature.

kakawait · 2020-06-01T11:35:22Z

Since the way that PR is dev, aka not breaking changes. So by reviewing it and merging it, you'll make many devs happy no and without breaking existing projects? :)

lordjaxom · 2020-06-09T06:59:17Z

+1
Would save us the hassle of introducing aggregator projects in 50+ repositories.

lordjaxom · 2020-06-10T23:24:56Z

Just to state a report, we are currently using jacoco 0.8.5 + issue-812 (built locally) successfully within 50+ repositories to have full and accurate coverage reports with SonarQube without having to fuss with any projects' pom (both report-aggregate and SonarQube are configured in a global parent pom of our project tree).

marchof · 2020-06-11T05:35:58Z

@lordjaxom Can you describe the structure of your repos and shortly explain why this modification helps? I want to understand the use case. Thx!

lordjaxom · 2020-06-12T11:58:49Z

We mostly have multi-module-projects for EJB components which are separated into shared and server modules. The shared part contains interfaces, DTOs and utility classes, while the server part contains entities and implementations.

Since structurally sometimes the tests are located within the server part (even though the test covers DTO and utility classes) or integration tests cover multiple components at once, we would need aggregate reports over two or more modules. Ideally those would be generated within the server part, covering both server and shared.

Without this flag, we would either have to aggregate ourselves the standard report (covering only the server part) and the aggregate report (covering only the shared part since only dependencies are scanned) or introduce a third module as suggested in various documents to cover classes from both modules. Since "report" only actually reports coverage for classes present in the current module (not dependencies) and "report-aggregate" only reports coverage for classes from the dependencies, not the project itself.

zuza-str · 2020-07-29T08:48:40Z

@marchof are there any other concerns to merge this change? It would really make the life easier for many JaCoCo users :)

henrik242

lgtm

twoodhouse · 2020-09-15T19:37:48Z

My company is being forced to use aggregator modules in lots of projects to get around this. We are looking forward to this option being merged!

cai3178940 · 2021-07-06T09:59:57Z

LGTM

bogaertg · 2021-12-28T14:48:40Z

up

jycr · 2022-01-29T14:34:30Z

@kakawait , @henrik242, @twoodhouse: what is missing now to be able to merge this PR into master and add this feature in the next version?

lyoumi · 2022-06-01T13:21:59Z

@lion7 @henrik242 @kakawait do we have any estimates for merging this PR to master?

kakawait · 2022-06-01T13:36:34Z

I'm not maintainer at all of Jacoco. I can't help you

lion7 · 2022-06-01T16:23:11Z

I'm willing to update this PR if one of the committers is willing to take a look at it.
Perhaps @Godin if he has time?

marchof · 2022-06-01T17:56:26Z

Hi @lion7, maintainer here. Thanks for your patience. Let's give it a try!

lion7 · 2022-06-01T18:23:03Z

@marchof great! 😄. I redid my changes on the current master, it should be ok now🤞🏻

jacoco-maven-plugin/src/org/jacoco/maven/ReportAggregateMojo.java

lyoumi · 2022-06-07T09:46:39Z

@marchof @lion7 just to follow up this review. Do we have any more concerns about this PR?

marchof · 2022-06-08T09:04:06Z

@lyoumi My concern is that all builds are broken due to a source formatting issue. I can help to fix this when I‘m back from vacation next week.

lion7 · 2022-06-08T09:30:44Z

@lyoumi My concern is that all builds are broken due to a source formatting issue. I can help to fix this when I‘m back from vacation next week.

Oh, I totally missed that in my last commit. I will try to fix the build asap 🙂

marchof · 2022-06-21T09:13:21Z

@Godin May you also have a look at this?

froque · 2022-10-06T10:00:39Z

Any chance of releasing 0.8.9 with this change ?

m-herold · 2023-03-18T15:06:45Z

Can't wait to start using the new includeCurrentProject parameter. Are there already plans when the new version 0.8.9 will be released?

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.maven.plugins:maven-compiler-plugin](https://maven.apache.org/plugins/) | build | minor | `3.10.1` -> `3.11.0` | | [org.jacoco:jacoco-maven-plugin](https://www.jacoco.org/jacoco/trunk/doc/maven.html) ([source](https://github.com/jacoco/jacoco)) | build | patch | `0.8.8` -> `0.8.10` | | [com.graphhopper:graphhopper-map-matching](https://www.graphhopper.com) ([source](https://github.com/graphhopper/graphhopper)) | compile | patch | `7.0` -> `7.0-testgithub6` | | [com.graphhopper:graphhopper-core](https://www.graphhopper.com) ([source](https://github.com/graphhopper/graphhopper)) | compile | patch | `7.0` -> `7.0-testgithub6` | | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.0.5` -> `3.0.6` | --- ### Release Notes <details> <summary>jacoco/jacoco</summary> ### [`v0.8.10`](https://github.com/jacoco/jacoco/releases/tag/v0.8.10): 0.8.10 [Compare Source](jacoco/jacoco@v0.8.9...v0.8.10) #### Fixed bugs - Agent should not require configuration of permissions for `SecurityManager` outside of its `codeBase` (GitHub [#1425](jacoco/jacoco#1425)). ### [`v0.8.9`](https://github.com/jacoco/jacoco/releases/tag/v0.8.9): 0.8.9 [Compare Source](jacoco/jacoco@v0.8.8...v0.8.9) #### New Features - JaCoCo now officially supports Java 19 and 20 (GitHub [#1371](jacoco/jacoco#1371), [#1386](jacoco/jacoco#1386)). - Experimental support for Java 21 class files (GitHub [#1386](jacoco/jacoco#1386)). - Add parameter to include the current project in the `report-aggregate` Maven goal (GitHub [#1007](jacoco/jacoco#1007)). - Component accessors generated by the Java compilers for records are filtered out during generation of report. Contributed by Tesla Zhang (GitHub [#1393](jacoco/jacoco#1393)). #### Fixed bugs - Agent should not open `java.lang` package to unnamed module of the application class loader (GitHub [#1334](jacoco/jacoco#1334)). #### Non-functional Changes - JaCoCo now depends on ASM 9.5 (GitHub [#1299](jacoco/jacoco#1299), [#1368](jacoco/jacoco#1368), [#1416](jacoco/jacoco#1416)). - JaCoCo build now requires JDK 11 (GitHub [#1413](jacoco/jacoco#1413)). </details> <details> <summary>graphhopper/graphhopper</summary> ### [`v7.0-pre2`](graphhopper/graphhopper@7.0-pre1...7.0-pre2) [Compare Source](graphhopper/graphhopper@7.0-pre1...7.0-pre2...

ramachandranms mentioned this pull request Feb 21, 2020

[HUDI-627] Aggregate code coverage and publish to codecov.io during CI apache/hudi#1347

Merged

5 tasks

marchof added component: maven type: enhancement labels Jun 9, 2020

marchof added this to the 0.8.6 milestone Jun 9, 2020

henrik242 approved these changes Aug 31, 2020

View reviewed changes

henrik242 mentioned this pull request Sep 15, 2020

Release 0.8.6 #1092

Closed

Godin removed this from the 0.8.6 milestone Sep 15, 2020

twoodhouse approved these changes Sep 15, 2020

View reviewed changes

kakawait approved these changes Nov 25, 2020

View reviewed changes

marchof reviewed Jun 2, 2022

View reviewed changes

jacoco-maven-plugin/src/org/jacoco/maven/ReportAggregateMojo.java Show resolved Hide resolved

lion7 and others added 4 commits June 21, 2022 10:35

Add parameter to include the current project in the aggregated report

fa44fba

Move processing of project to a separate method

5d6770b

Fix source formatting

4799356

Update change log

e5498b1

marchof approved these changes Jun 21, 2022

View reviewed changes

marchof self-assigned this Jun 21, 2022

marchof requested a review from Godin June 21, 2022 09:12

marchof mentioned this pull request Jun 21, 2022

Add current project to report aggregate #970

Closed

Godin approved these changes Jun 27, 2022

View reviewed changes

Merge branch 'master' into issue-812

f22e3be

Godin merged commit af33753 into jacoco:master Jun 27, 2022

Godin added this to the 0.8.9 milestone Jun 27, 2022

lion7 deleted the issue-812 branch June 27, 2022 16:55

MikeEdgar mentioned this pull request Oct 18, 2022

Document includeCurrentProject available as of 0.8.9 #1377

Merged

This was referenced Jan 18, 2023

[fix][ci] Fix Jacoco code coverage to report classes in dependent projects apache/pulsar#19264

Merged

CLI: adding filtering support into instrumentation and into reporting #537

Open

paulo-santos mentioned this pull request Jun 1, 2023

report-aggregate does not include report from current project #812

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add parameter to include the current project in the aggregated report #1007

Add parameter to include the current project in the aggregated report #1007

lion7 commented Jan 30, 2020 •

edited

Loading

ramachandranms commented Feb 21, 2020

pertsodian commented Mar 20, 2020 •

edited

Loading

kakawait commented Jun 1, 2020 •

edited

Loading

lordjaxom commented Jun 9, 2020

lordjaxom commented Jun 10, 2020

marchof commented Jun 11, 2020

lordjaxom commented Jun 12, 2020

zuza-str commented Jul 29, 2020

henrik242 left a comment

twoodhouse commented Sep 15, 2020

cai3178940 commented Jul 6, 2021

bogaertg commented Dec 28, 2021

jycr commented Jan 29, 2022

lyoumi commented Jun 1, 2022

kakawait commented Jun 1, 2022

lion7 commented Jun 1, 2022

marchof commented Jun 1, 2022

lion7 commented Jun 1, 2022

lyoumi commented Jun 7, 2022 •

edited

Loading

marchof commented Jun 8, 2022

lion7 commented Jun 8, 2022

marchof commented Jun 21, 2022

froque commented Oct 6, 2022

m-herold commented Mar 18, 2023

Add parameter to include the current project in the aggregated report #1007

Add parameter to include the current project in the aggregated report #1007

Conversation

lion7 commented Jan 30, 2020 • edited Loading

ramachandranms commented Feb 21, 2020

pertsodian commented Mar 20, 2020 • edited Loading

kakawait commented Jun 1, 2020 • edited Loading

lordjaxom commented Jun 9, 2020

lordjaxom commented Jun 10, 2020

marchof commented Jun 11, 2020

lordjaxom commented Jun 12, 2020

zuza-str commented Jul 29, 2020

henrik242 left a comment

Choose a reason for hiding this comment

twoodhouse commented Sep 15, 2020

cai3178940 commented Jul 6, 2021

bogaertg commented Dec 28, 2021

jycr commented Jan 29, 2022

lyoumi commented Jun 1, 2022

kakawait commented Jun 1, 2022

lion7 commented Jun 1, 2022

marchof commented Jun 1, 2022

lion7 commented Jun 1, 2022

lyoumi commented Jun 7, 2022 • edited Loading

marchof commented Jun 8, 2022

lion7 commented Jun 8, 2022

marchof commented Jun 21, 2022

froque commented Oct 6, 2022

m-herold commented Mar 18, 2023

lion7 commented Jan 30, 2020 •

edited

Loading

pertsodian commented Mar 20, 2020 •

edited

Loading

kakawait commented Jun 1, 2020 •

edited

Loading

lyoumi commented Jun 7, 2022 •

edited

Loading