-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for parameter types. #206
Conversation
Not sure that we can always assume is_numeric is an integer. What about Not sure about defaulting to null on execute rather than an empty array
|
Good call on the As for defaulting to null on execute, thats only used in the Mock PDO Statement object and is so that it's easy to differentiate when someone passes an array to the function. The variable gets replaced if its NULL and if it's an array it gets left alone. |
Only make integers type int, all other number types get passed as strings.
Why is |
@charsleysa the question from @cainmi was going to be my very next question now I am in front of a computer again instead of on my phone. |
Sorry, habit from Javascript, will patch. |
Solves #196