Issue 92 aggregate functions always returning ints

j4mie · Jan 11, 2013 · f4b107c · f4b107c
1 parent 2c16789
commit f4b107c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/README.markdown b/README.markdown
@@ -48,6 +48,7 @@ Changelog
 * Fix when using `set_expr` alone it doesn't trigger query creation - closes issue #90
 * Escape quote symbols in "_quote_identifier_part" - close issue #74
 * Add HAVING clause functionality
+* Fix issue with aggregate functions always returning `int` when is `float` sometimes required - closes issue #92
 
 #### 1.2.3 - release 2012-11-28
 

diff --git a/idiorm.php b/idiorm.php
@@ -514,7 +514,16 @@ protected function _call_aggregate_db_function($sql_function, $column) {
             }
             $this->select_expr("$sql_function($column)", $alias);
             $result = $this->find_one();
-            return ($result !== false && isset($result->$alias)) ? (int) $result->$alias : 0;
+
+            $return_value = 0;
+            if($result !== false && isset($result->$alias)) {
+                if((int) $result->$alias == (float) $result->$alias) {
+                    $return_value = (int) $result->$alias;
+                } else {
+                    $return_value = (float) $result->$alias;
+                }
+            }
+            return $return_value;
         }
 
          /**