Add Questionable Condition register #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add same line to new tests for parity.
j123b567
requested changes
Nov 30, 2017
libscpi/test/test_parser.c
Outdated
| @@ -439,6 +440,12 @@ static void testIEEE4882(void) { | |||
| TEST_IEEE4882("STATus:QUEStionable:ENABle 2\r\n", ""); | |||
| TEST_IEEE4882_REG(SCPI_REG_QUESE, 2); | |||
|
|
|||
| EST_IEEE4882("STATus:QUEStionable:CONDition?\r\n", "0\r\n"); | |||
There was a problem hiding this comment.
You have typo in this line EST -> TEST. See travis build
libscpi/test/test_parser.c
Outdated
| @@ -461,6 +462,7 @@ static void testIEEE4882(void) { | |||
| TEST_IEEE4882("STATus:OPERation:CONDition?\r\n", "0\r\n"); | |||
| TEST_IEEE4882_REG_SET(SCPI_REG_OPERC, 1); | |||
| TEST_IEEE4882("STATus:OPERation:CONDition?\r\n", "1\r\n"); | |||
| TEST_IEEE4882_REG(SCPI_REG_OPERC, 1); | |||
There was a problem hiding this comment.
TEST_IEEE4882 tests outer behavior of the library, so how it communicates
TEST_IEEE4882_REG tests inner behavior of the library, so if the register has really the expected value.
There was a problem hiding this comment.
Yea, I understand. When I removed it I was thinking that this line was setting the register, but then I realized that it was actually verifying that the value didn't change after being read by the SCPI query.
libscpi/test/test_parser.c
Outdated
| @@ -78,6 +78,7 @@ static const scpi_command_t scpi_commands[] = { | |||
| { .pattern = "SYSTem:VERSion?", .callback = SCPI_SystemVersionQ,}, | |||
|
|
|||
| { .pattern = "STATus:QUEStionable[:EVENt]?", .callback = SCPI_StatusQuestionableEventQ,}, | |||
| { .pattern = "STATus:QUEStionable:CONDition?", .callback = SCPI_Status_QuestionableConditionQ,}, | |||
There was a problem hiding this comment.
You have typo in function name SCPI_Status_QuestionableConditionQ -> SCPI_StatusQuestionableConditionQ. See travis build
j123b567
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I left out the Questionable Condition register in my previous PR, so here it is!