misspell #60
Merged
misspell #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo
fix typo
fix typo
fix typo
fix typo
add err != nil test + fix typo
izumin5210
reviewed
Apr 17, 2018
| @@ -128,6 +128,10 @@ func Test_Script(t *testing.T) { | |||
| if got, want := exec.dir, "/home/app"; got != want { | |||
| t.Errorf("Run() executed a command in %v, want %v", got, want) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Trailing space is here 👀
Can you remove it?
remove Trailing space
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 49.12% 49.12%
=======================================
Files 36 36
Lines 1321 1321
=======================================
Hits 649 649
Misses 624 624
Partials 48 48
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix typo