Support (*grpcserver.Engine).ServeContext(context.Context) and use it in default #183
Conversation
|
|
||
| if internalLis != nil { | ||
| eg.Go(func() error { return grpcServer.Serve(internalLis) }) | ||
| eg.Go(func() error { return grpcServer.Serve(ctx, internalLis) }) |
There was a problem hiding this comment.
[wraperr] reported by reviewdog 🐶
pkg/grapiserver/engine.go:90:31: eg.Go(func() error { return grpcServer.Serve(ctx, internalLis) })
|
|
||
| if internalLis != nil { | ||
| eg.Go(func() error { return grpcServer.Serve(internalLis) }) | ||
| eg.Go(func() error { return grpcServer.Serve(ctx, internalLis) }) |
There was a problem hiding this comment.
[wraperr] reported by reviewdog 🐶
pkg/grapiserver/engine.go:90:31: eg.Go(func() error { return grpcServer.Serve(ctx, internalLis) })
| } | ||
| if grpcLis != nil { | ||
| eg.Go(func() error { return grpcServer.Serve(grpcLis) }) | ||
| eg.Go(func() error { return grpcServer.Serve(ctx, grpcLis) }) |
There was a problem hiding this comment.
[wraperr] reported by reviewdog 🐶
pkg/grapiserver/engine.go:93:31: eg.Go(func() error { return grpcServer.Serve(ctx, grpcLis) })
| } | ||
| if grpcLis != nil { | ||
| eg.Go(func() error { return grpcServer.Serve(grpcLis) }) | ||
| eg.Go(func() error { return grpcServer.Serve(ctx, grpcLis) }) |
There was a problem hiding this comment.
[wraperr] reported by reviewdog 🐶
pkg/grapiserver/engine.go:93:31: eg.Go(func() error { return grpcServer.Serve(ctx, grpcLis) })
| } | ||
| if muxServer != nil { | ||
| eg.Go(func() error { return muxServer.Serve(nil) }) | ||
| eg.Go(func() error { return gatewayServer.Serve(ctx, gatewayLis) }) |
There was a problem hiding this comment.
[wraperr] reported by reviewdog 🐶
pkg/grapiserver/engine.go:96:31: eg.Go(func() error { return gatewayServer.Serve(ctx, gatewayLis) })
| } | ||
| if muxServer != nil { | ||
| eg.Go(func() error { return muxServer.Serve(nil) }) | ||
| eg.Go(func() error { return gatewayServer.Serve(ctx, gatewayLis) }) |
There was a problem hiding this comment.
[wraperr] reported by reviewdog 🐶
pkg/grapiserver/engine.go:96:31: eg.Go(func() error { return gatewayServer.Serve(ctx, gatewayLis) })
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=========================================
+ Coverage 61.17% 61.57% +0.4%
=========================================
Files 39 39
Lines 1378 1395 +17
=========================================
+ Hits 843 859 +16
- Misses 474 476 +2
+ Partials 61 60 -1
Continue to review full report at Codecov.
|
WHY
To close #151