Support Modules #176
Merged
Support Modules #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubrabbit
reviewed
Mar 21, 2019
| @@ -25,10 +25,11 @@ func ProvideScriptLoader(ctx *grapicmd.Ctx, executor excmd.Executor) module.Scri | |||
| return script.NewLoader(ctx.FS, executor, ctx.RootDir.String()) | |||
| } | |||
|
|
|||
| func ProvideInitializeProjectUsecase(ctx *grapicmd.Ctx, gexCfg *gex.Config, ui cli.UI, generator module.Generator) usecase.InitializeProjectUsecase { | |||
| func ProvideInitializeProjectUsecase(ctx *grapicmd.Ctx, gexCfg *gex.Config, ui cli.UI, generator module.Generator, excmd excmd.Executor) usecase.InitializeProjectUsecase { | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function ProvideInitializeProjectUsecase should have comment or be unexported
hubrabbit
reviewed
Mar 21, 2019
| funcMap := template.FuncMap{ | ||
| "module": func(in string) (string, error) { | ||
| if isMod { | ||
| return e.getModulePath(ctx, in) |
There was a problem hiding this comment.
[wraperr] reported by reviewdog 🐶
pkg/protoc/wrapper.go:140:12: return e.getModulePath(ctx, in)
hubrabbit
reviewed
Mar 21, 2019
|
|
||
| func (e *wrapperImpl) commands(ctx context.Context, protoPath string) ([][]string, error) { | ||
| cmds := make([][]string, 0, len(e.cfg.Plugins)) | ||
| relProtoPath, _ := filepath.Rel(e.rootDir.String(), protoPath) |
There was a problem hiding this comment.
[errcheck] reported by reviewdog 🐶
relProtoPath, _ := filepath.Rel(e.rootDir.String(), protoPath)
izumin5210
force-pushed
the
izumin5210/mod
branch
from
7acb2e8 to
0b7cf5a
Compare
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=========================================
- Coverage 61.67% 61.17% -0.5%
=========================================
Files 39 39
Lines 1328 1378 +50
=========================================
+ Hits 819 843 +24
- Misses 452 474 +22
- Partials 57 61 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83