Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RxJava2 #52

Merged
merged 20 commits into from
Jan 16, 2018
Merged

Update to RxJava2 #52

merged 20 commits into from
Jan 16, 2018

Conversation

wakwak3125
Copy link
Collaborator

@wakwak3125 wakwak3125 commented Jan 2, 2018

Update to RxJava2

  • Pass all build on local build
  • Pass all build on Travis.
  • Test sample projects.
    • TodoMVC
    • Counter
    • Todo-with-dagger
    • Todo-with-undo
  • Remove RxJava1 dependency from all projects
  • Update README.md

Some generated code changed.

When user add observeXXX(BackpressureStrategy strategy), the processor generates these code block.

  @Override
  public Flowable<Counter> observeCounter(BackpressureStrategy strategy) {
     return counterStoreImpl.observe(strategy);
  }

@wakwak3125 wakwak3125 requested a review from izumin5210 January 3, 2018 11:44
@wakwak3125 wakwak3125 self-assigned this Jan 3, 2018
@wakwak3125 wakwak3125 changed the title [WIP] Update to RxJava2 Update to RxJava2 Jan 3, 2018
@wakwak3125
Copy link
Collaborator Author

@izumin5210
I updated dependencies that related to the RxJava 👍
Could you review this PR carefully?

Copy link
Owner

@izumin5210 izumin5210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@izumin5210 izumin5210 merged commit 8510117 into master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants