checkstyle_parameter #297
Merged
checkstyle_parameter #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbagu
reviewed
Oct 26, 2017
| @@ -184,10 +184,11 @@ public void run(CommandLine line, ToolRunningContext context) throws Exception { | |||
| private void printStateStepViolations(TableFormatter formatter, Integer stateId, OnlineStep step, List<LimitViolation> violations, | |||
| LimitViolationFilter violationsFilter) { | |||
| if (violations != null) { | |||
| List<LimitViolation> filtedViolations = violations; | |||
| @@ -184,10 +184,11 @@ public void run(CommandLine line, ToolRunningContext context) throws Exception { | |||
| private void printStateContingencyViolations(TableFormatter formatter, Integer stateId, String contingencyId, List<LimitViolation> violations, | |||
| LimitViolationFilter violationsFilter) { | |||
| if (violations != null) { | |||
| List<LimitViolation> filtedViolations = violations; | |||
| @@ -106,9 +106,6 @@ private RulesFacadeResults evaluate(String networkId, String stateId, Map<HistoD | |||
| boolean dynamicIndexUnsafe = false; | |||
| if (checkRules) { | |||
| checkRules(rules, invalidRulesIndexes, bacecaseInvalidRulesIndexes); | |||
| if ("0".equals(stateId)) { | |||
There was a problem hiding this comment.
Why do you remove this block?
There was a problem hiding this comment.
Reassignement a pararmeter is not allowed and this one is not used after this statement, so i did not created a new XXX xxx = instanceFromParameter(as i do in other case)
| if (contingencyIds != null && !contingencyIds.isEmpty()) { | ||
| runAnalysis = true; | ||
| } | ||
| if (runAnalysis) { |
There was a problem hiding this comment.
Seems obvious... can you try to write it simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.