Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pull request template for istio. #946

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Updated pull request template for istio. #946

merged 1 commit into from
Sep 27, 2017

Conversation

gyliu513
Copy link
Member

Release note:

NONE

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: douglas-reid

Assign the PR to them by writing /assign @douglas-reid in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@andraxylia
Copy link
Contributor

/tickle

@andraxylia andraxylia merged commit 23c9204 into istio:master Sep 27, 2017
@gyliu513 gyliu513 deleted the pull-request branch September 28, 2017 02:08
rshriram pushed a commit that referenced this pull request Oct 30, 2017
vbatts pushed a commit to vbatts/istio that referenced this pull request Oct 31, 2017
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
* upload istioctl as part of prow/presubmit

* add e2e smoktest for pilot

* add note about implicit kubeconfig dependency

* address temp dir

* properly remove dir

* prefix with .

* download logs and put in artifacts

* fix style

* address seb's comments

* fix artifacts dir
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of proxy

This PR will be merged automatically once checks are successful.
```release-note
none
```
0x01001011 pushed a commit to thedemodrive/istio that referenced this pull request Jul 16, 2020
* Modify upstream links that changed in envoy docs

See PR: https://github.com/istio/istio.io/pull/4424/files

This was an emergency blockage during the last few days of release
1.2, so the exact process of modifying API first then modifying docs
was not done.  Instead, sadly it felt backwards (modify docs first,
then modify this repo).

* Run make after modifying protos

This generates the go commented PI as well as the proto HTML
documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants