-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pull request template for istio. #946
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/tickle |
Former-commit-id: 23c9204
* upload istioctl as part of prow/presubmit * add e2e smoktest for pilot * add note about implicit kubeconfig dependency * address temp dir * properly remove dir * prefix with . * download logs and put in artifacts * fix style * address seb's comments * fix artifacts dir
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
* Modify upstream links that changed in envoy docs See PR: https://github.com/istio/istio.io/pull/4424/files This was an emergency blockage during the last few days of release 1.2, so the exact process of modifying API first then modifying docs was not done. Instead, sadly it felt backwards (modify docs first, then modify this repo). * Run make after modifying protos This generates the go commented PI as well as the proto HTML documentation.
Release note: