Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change issue template to use brackets instead of italics for readability #8012

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

ZackButcher
Copy link
Contributor

@ZackButcher ZackButcher commented Aug 17, 2018

Thanks for getting rid of the <sup>, that was very hard to read, but I still have a hard time reading the italics. This just updates the template to surround the info text with brackets {{ like this }} to denote that the user should fill them in, rather than like this. I think it still gets the point across but makes issues more readable by using a normal font. Brackets are arbitrary, but harken to the golang template syntax.

Compare the rendered markdown :


Is your feature request related to a problem? Please describe.
{{ A clear and concise description of what the problem is. }}

Describe the solution you'd like
{{ A clear and concise description of what you want to happen. }}

Describe alternatives you've considered
{{ A clear and concise description of any alternative solutions or features you've considered. }}

Additional context
{{ Add any other context about the feature request here. }}


Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context about the feature request here.


…ckets to denote text that the user should replace
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher

If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

@ZackButcher: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh e6d2aef link /test istio-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid
Copy link
Contributor

douglas-reid commented Aug 17, 2018

This probably boils down to personal prefs 😄.

If we get rid of italics, I would vote for just plain text (no brackets) or just removing that text altogether.

About the only value that text provides is a reminder to be "clear and concise" (which we repeat three times 😛). We could just add a intro warning that says something like "Please be clear and concise in all descriptions so that others can more quickly identify the crux of your issue."

Or just update the headers to be something like (and remove the text):

  • ... Please describe clearly and concisely.
  • Clearly and concisely describe your desired solution...
  • Clearly and concisely describe alternatives...
  • Provide any additional context here.

@geeknoid geeknoid merged commit 034c0c7 into istio:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants