proxy network label should be set based on pod labels, system namespa… #54513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce labels and meshNetwork config
istio-testing
added
the
size/M
howardjohn
reviewed
Jan 2, 2025
| @@ -286,13 +287,34 @@ func TestNewEndpointBuilderFromMetadataTopologyLabels(t *testing.T) { | |||
| }, | |||
| opts: Options{ClusterID: c.ctl.cluster}, | |||
| } | |||
| eb := cc.NewEndpointBuilderFromMetadata(c.proxy) | |||
| eb := newEndpointBuilderFromMetadata(cc, c.proxy) | |||
There was a problem hiding this comment.
is this test doing anything? it seems we are testing newEndpointBuilderFromMetadata but that function is now deadcode
There was a problem hiding this comment.
Yeah, i just realized it
hzxuzhonghu
added
the
release-notes-none
istio-testing
added
size/L
|
LGTM |
howardjohn
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ce labels and meshNetwork config
Please provide a description of this PR:
Fix #54381