Use the zone from the metadata for creating locality #53821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/M
ingwonsong
added
the
release-notes-none
|
/test release-notes |
howardjohn
requested changes
Nov 7, 2024
ingwonsong
force-pushed
the
using-metadata-for-zone
branch
from
564ef7a to
a3f346f
Compare
Change-Id: I27f1b699f7ea464eb43993eb7870ee15f7ffc8ad
ingwonsong
force-pushed
the
using-metadata-for-zone
branch
from
a3f346f to
52f395e
Compare
Change-Id: I63c0f955d6ed3a6051e34baa05ef9f05bbd46001
istio-testing
added
size/L
Actually, it was not, but I realized that it is great to solve the issue together. So, we are now using zone of Pod, not the cluster's zone. |
howardjohn
reviewed
Nov 7, 2024
|
/retest |
Change-Id: Iac06b870add610464da13bc92d54817b8f5753bb
2 tasks
kyessenov
reviewed
Nov 8, 2024
kyessenov
reviewed
Nov 8, 2024
|
Implementation looks fine to me except the two comments above. |
Change-Id: Ibc72d0dc3800fca7de781edb3858e454fdb9716b
Change-Id: I5e38ccdc61621d933e595bfab9a45a0bede1bc32
|
/retest |
kyessenov
approved these changes
Nov 9, 2024
howardjohn
approved these changes
Nov 9, 2024
This was referenced Nov 11, 2024
MaYuan-02
pushed a commit
to MaYuan-02/istio
that referenced
this pull request
Dec 8, 2024
* Use the zone from the metadata Change-Id: I27f1b699f7ea464eb43993eb7870ee15f7ffc8ad * Fix the test cases. Change-Id: I63c0f955d6ed3a6051e34baa05ef9f05bbd46001 * Reduce the timeout to 3 sec Change-Id: Iac06b870add610464da13bc92d54817b8f5753bb * Reflect comments and add GCP_ZONE env var for overriding Change-Id: Ibc72d0dc3800fca7de781edb3858e454fdb9716b * Fix the failure in the unit test Change-Id: I5e38ccdc61621d933e595bfab9a45a0bede1bc32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation is assuming that the cluster location is "zone" when creating Locality for GCP platform.
However, for the GKE regional cluster, it is not true.
Therefore, this PR proposes to use "metadata" server to get the zone, if the cluster location is not zonal.
Change-Id: I27f1b699f7ea464eb43993eb7870ee15f7ffc8ad