Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply missing secret filter for discoverySelector #53175

Merged

Conversation

howardjohn
Copy link
Member

This was the one missing spot for the filter

This was the one missing spot for the filter
@howardjohn howardjohn requested a review from a team as a code owner September 17, 2024 16:00
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Sep 17, 2024
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2024
Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@istio-testing istio-testing merged commit 7039b8b into istio:master Sep 17, 2024
27 checks passed
@zirain
Copy link
Member

zirain commented Sep 18, 2024

@howardjohn need to backport?

luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024
* upstream/master:
  ambient: fix add+remove+add of iptables (istio#53063)
  Apply missing secret filter for discoverySelector (istio#53175)
  ambient: only set app tunnel if configured (istio#53155)
  Automator: update proxy@master in istio/istio@master (istio#53173)
  Fix bookinfo MongoDB on IPv6 cluster (istio#53072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants